Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two fixes: #19

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Two fixes: #19

merged 5 commits into from
Aug 16, 2023

Conversation

luciansmith
Copy link
Contributor

  • Better error message for trying to change local parameter in a task
  • Correctly store task change targets in nested repeated tasks.

* Better error message for trying to change local parameter in a task
* Correctly store task change targets in nested repeated tasks.
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.25% ⚠️

Comparison is base (705eeb0) 92.43% compared to head (e8c71cd) 92.18%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #19      +/-   ##
==========================================
- Coverage   92.43%   92.18%   -0.25%     
==========================================
  Files           6        6              
  Lines         436      448      +12     
==========================================
+ Hits          403      413      +10     
- Misses         33       35       +2     
Flag Coverage Δ
unittests 92.18% <80.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
biosimulators_tellurium/core.py 91.07% <78.94%> (-0.25%) ⬇️
biosimulators_tellurium/_version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luciansmith luciansmith merged commit e8cf9ec into dev Aug 16, 2023
1 of 3 checks passed
@luciansmith luciansmith deleted the fixes branch August 16, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant