[ENH] Paint Data: Slight optimization #6990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ales-erjavec, this seems to fix things. I don't get a slowdown anymore. I tried Previously, when there were many (~500 points) the painting didn't catch up with the mouse action, meaning that when I released the button, the points still kept coming in. Thanks! |
ales-erjavec
force-pushed
the
paint-data-opt
branch
from
f244bab to
884a7a3
Compare
Speeds up the undo/redo. Cleanup merging by replacing slices with ranges.
ales-erjavec
force-pushed
the
paint-data-opt
branch
from
884a7a3 to
d23c197
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6990 +/- ##
==========================================
- Coverage 88.47% 88.46% -0.01%
==========================================
Files 332 332
Lines 73294 73314 +20
==========================================
+ Hits 64847 64859 +12
- Misses 8447 8455 +8 |
ales-erjavec
force-pushed
the
paint-data-opt
branch
from
5d6f885 to
4bce83e
Compare
Add tests
ales-erjavec
force-pushed
the
paint-data-opt
branch
from
4bce83e to
b7673dc
Compare
'undoable' param was passed from triggered signal (checked state). This was wrong.
ales-erjavec
force-pushed
the
paint-data-opt
branch
from
b7673dc to
e7fd9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref: #6971
Description of changes
Slight optimization. Most of the time still spent in ScatterPlotItem constructor.
Includes