CI: Install pymssql separately #6903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
pymssal-on-macos
branch
2 times, most recently
from
eec7f8c
to
ee34fdf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6903 +/- ##
==========================================
- Coverage 88.19% 88.15% -0.05%
==========================================
Files 326 326
Lines 71233 71233
==========================================
- Hits 62827 62797 -30
- Misses 8406 8436 +30 |
janezd
force-pushed
the
pymssal-on-macos
branch
5 times, most recently
from
07cc851
to
664863c
Compare
janezd
force-pushed
the
pymssal-on-macos
branch
4 times, most recently
from
228165d
to
87ba877
Compare
janezd
force-pushed
the
pymssal-on-macos
branch
from
87ba877
to
6d5625e
Compare
|
I give up. I guess we should abandon tests on macOS that requires pymssql until pymssql installation is fixed. I hope we distribute a working version of pymssql in released Orange? |
|
I think (did not check) we don't even distribute pymssql. And if we do, we have tests there anyway that would catch if something was wrong. |
Where? |
When we create packages, we run all the tests on the installed package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at fixing failing tests on macOS with Python >= 3.11.