test_pandas: Remove a failing test caused by pytz #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6895 +/- ##
==========================================
- Coverage 88.26% 88.18% -0.09%
==========================================
Files 326 326
Lines 71188 71194 +6
==========================================
- Hits 62834 62781 -53
- Misses 8354 8413 +59 |
janezd
force-pushed
the
fix-pytz-regression
branch
from
4eba6c3
to
a369c14
Compare
|
Today i learned that time zones are more complicated than I thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
pytz 2024.2 seems to have changed treatment of DST and of timezones, which broke our tests.
Description of changes
The failing assertion could be fixed, but we prefer removing it: it was a test of pytz regressions rather than of our code.