[ENH] File: Allow selecting files with arbitrary extensions #6894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #6792. Requires biolab/orange-widget-base#278 (without, it should work, but without offering the . option).
Description of changes
Following the discussion with @markotoplak, I propose the following.
Readers are determined as follows:
Notes:
Usage scenarios
Here are a few interesting sequences and the way they are resolved according to the above rules, which should also serve to write tests if we agree upon this.
In the following "Load" refers to clicking ... and selecting the file in directory, and "Select" refers to selecting the file from the recent file list.
(... continues in 3)
(continued from above)
Notes
add_all="*"
and a few different error messages, the most complicate change is in_get_reader
. Reviewer should concentrate on this.mark_problematic_reader
was needed because the combo state was not changed to the reader from the recent path. This is no longer the case._initialize_reader_combo
could be shorter (block signals, reinitialize, set the current index to previous value), but the current form makes its function more explicit.Includes