-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context handler that respects position in Domain #6740
base: master
Are you sure you want to change the base?
Conversation
5286762
to
ad7a9a2
Compare
I tried adding dummy So I can't make these compatible, at least not that simple. |
A combo box for choosing row annotation color is limited to metas and class vars, and thus, when a selected feature was moved from metas to attributes, an incompatible context would match. That did not trigger any crashes because the combo box was updated through special functions, but it did leave the UI in an inconsistent state: an element with index of -1 was selected in the combo (""), and, the saved color was still shown in the map.
f626e12
to
8ae78d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6740 +/- ##
=======================================
Coverage 88.26% 88.27%
=======================================
Files 326 326
Lines 71142 71192 +50
=======================================
+ Hits 62797 62847 +50
Misses 8345 8345 |
8ae78d5
to
6ae47bf
Compare
6637d44
to
bb6d785
Compare
bb6d785
to
761506b
Compare
Issue
Resolves #6721
Description of changes
Added a new context handler that respects context settings' attributes
exclude_attributes
,exclude_metas
andexclude_class_vars
. This context handler avoids storing the whole domain into settings and thus perfect matches do not work.I searched for possible instances of #6721 in this repo and found only 3 cases where a limited
DomainModel
was used for a context settings, out of which only 1 was problematic:feature_model
: not a problem, because it is applied to a processed data set where every possible feature is moved into.attributes
.feature_model
(for CV by Feature): not the same problem, because it usesPerfectDomainHandler
.row_side_color_model
: finally, a bug. It this case, because of heavy customization, there were no crashes but UI was in an inconsistent state.In Heat Map, a combo box for choosing row annotation color is limited to metas and class vars, and thus, when a selected feature was moved from metas to attributes, an incompatible context would match. That did not trigger any crashes because the combo box was updated through special functions, but it did leave the UI in an inconsistent state: an element with index of -1 was selected in the combo (""), and, the saved color was still shown in the map. Fixed by using the proposed ContextHandler.
Includes