[FIX] Writers: Store nans in StringVariable as empty strings instead of 'nan' #6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6670 +/- ##
=======================================
Coverage 88.10% 88.11%
=======================================
Files 321 321
Lines 69950 69951 +1
=======================================
+ Hits 61631 61634 +3
+ Misses 8319 8317 -2 |
|
I think this should be made specific to CSV writer. Any reason you did not make it that way? Tab writers work well as they are and this fix would there only introduce new ambiguities. |
|
Ignore the previous comment. I need to check what did it do in write/read combination. If the old .tab behavior was already broken, I have no objections. |
|
Our tab saving was also broken, because it saved a string |
markotoplak
changed the title
markotoplak
changed the title
3 tasks
stuart-cls
added a commit
to stuart-cls/orange3
that referenced
this pull request
Mar 7, 2024
In fixing this, switched string handling from fixed-length to variable length https://docs.h5py.org/en/stable/special.html#variable-length-strings
stuart-cls
added a commit
to stuart-cls/orange3
that referenced
this pull request
Apr 25, 2024
In fixing this, switched string handling from fixed-length to variable length https://docs.h5py.org/en/stable/special.html#variable-length-strings
stuart-cls
added a commit
to stuart-cls/orange3
that referenced
this pull request
Sep 27, 2024
In fixing this, switched string handling from fixed-length to variable length https://docs.h5py.org/en/stable/special.html#variable-length-strings
stuart-cls
added a commit
to stuart-cls/orange3
that referenced
this pull request
Nov 5, 2024
In fixing this, switched string handling from fixed-length to variable length https://docs.h5py.org/en/stable/special.html#variable-length-strings
stuart-cls
added a commit
to stuart-cls/orange3
that referenced
this pull request
Nov 5, 2024
In fixing this, switched string handling from fixed-length to variable length https://docs.h5py.org/en/stable/special.html#variable-length-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6527.
Description of changes
The function that creates a string representation for storing values in file didn't expect that a
StringVariablecan benp.nan. Now it does.Our handling of StringVariable unknowns is a mess; the Table widget will apparently sometimes show
nan. This must be solved in general. The present PR only fixes the crash in saving of Excel files.Includes