Table: Assure unique table.ids when unpickling #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
pickle_ids
branch
from
a31b3cc
to
dc6f2c4
Compare
|
/rebase |
biolab-helper
force-pushed
the
pickle_ids
branch
from
dc6f2c4
to
a07c412
Compare
|
This is crazy! Changing setstate seems to have broken linux tests. Linux runs SQL tests too and our tests just freeze after a while. |
The previous version used obj.X.shape inside the locked part, but the problem was that SqlTable downloaded data when .X was accessed, which in turn run another _init_ids within. Now deadlocks should be impossible as the locked part only deals with primitive variables.
|
I figured out why tests froze. There was a deadlock on unpickling, when fresh ids were assigned for SqlTable. The old version of I fixed the deadlock. Then I noticed that @VesnaT's original ids fix always caused data download for SqlTables, which I hope I fixed in the following commits. In doing so I also had to free SqlTables from locking, because pickling tables with downloaded data did not work. |
markotoplak
force-pushed
the
pickle_ids
branch
from
9c2be5d
to
d44bc81
Compare
markotoplak
force-pushed
the
pickle_ids
branch
from
d44bc81
to
9fb7554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Different Tables could have the same ids when unpickled.
Description of changes
Create new table.ids in
__setstate__.Includes