Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New category colors #5287

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

New category colors #5287

wants to merge 1 commit into from

Conversation

irgolic
Copy link
Member

@irgolic irgolic commented Feb 19, 2021

Use with biolab/orange-canvas-core#175

Description of changes
  • new category colors
  • pyqtgraph fixes (WIP)
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #5287 (8263d9c) into master (878ea9b) will decrease coverage by 2.20%.
The diff coverage is 88.54%.

❗ Current head 8263d9c differs from pull request most recent head a0ae4fe. Consider uploading reports for the commit a0ae4fe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5287      +/-   ##
==========================================
- Coverage   87.40%   85.21%   -2.20%     
==========================================
  Files         317      300      -17     
  Lines       68228    61215    -7013     
==========================================
- Hits        59634    52163    -7471     
- Misses       8594     9052     +458     

@janezd
Copy link
Contributor

janezd commented Sep 30, 2021

Is this still relevant? To my understanding, this was moved to #5526, which has already been merged.

@markotoplak markotoplak force-pushed the dark-mode branch 3 times, most recently from 57ed696 to 392cd5c Compare March 6, 2023 13:23
@markotoplak markotoplak changed the title Dark mode support New category colors Mar 6, 2023
@markotoplak
Copy link
Member

I cleaned this up a bit. I removed parts that were already merged or were already implemented differently. This leaves category colors.

@markotoplak
Copy link
Member

The modifications here use the same colors as defined in this file. The (afterwards) added Preprocess category is missing.

orange_baloons_colors.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants