Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasources - Small refactoring #260

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Aug 23, 2023

Issue
  • While considering Fix Yahoo Finance Import #257, I found that the code can be refactored.
  • Aggregation tests are failing since Scipy changed the behaviour of stats functions.
Description of changes
  • Refactoring the code of the Datasources module.
  • Fix weighted_mode function: Before stats.mode had keepdims=True like behaviour by default, which changed in 1.11. Since it is False, now the result is a one-dimensional vector, so I removed the part of the code that extracts the first column. I also limited the version of Scipy to >=1.9 since it is the first version offering the keepdims parameter.
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the yahoo-small-fix branch 4 times, most recently from d117e5e to a2408b0 Compare August 24, 2023 06:04
@PrimozGodec PrimozGodec merged commit 3f00db0 into biolab:master Aug 24, 2023
11 of 12 checks passed
@PrimozGodec PrimozGodec deleted the yahoo-small-fix branch August 24, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant