Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/screenshots #79

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Feature/screenshots #79

merged 4 commits into from
Dec 18, 2023

Conversation

mitjapotocin
Copy link
Collaborator

@mitjapotocin mitjapotocin commented Dec 8, 2023

  • added screenshots on /screenshots page

Todos @markotoplak:

  • chekck if design is ok, otherwise ask Agnieszka for some help
  • there are two screenshots with the same title Interactive gradient descent.
  • check if sorting is corret. currently ascending by weight

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orange-web2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 11:16am

@markotoplak
Copy link
Member

Design is fine. Ascending order would be fine, but these need to be sorted numerically (maybe now you're sorting strings, because the order differs from https://oldorange.biolab.si/screenshots/)

@markotoplak
Copy link
Member

The text in public/screenshots/predicting_text_categories.md should probably be "Predicting text categories.". Thanks finding it.

@markotoplak
Copy link
Member

Also, I understand that .thumb variants would be useful if someone wanted to do a special thumbnail, but could they perhaps be automatically generated if not present?

@markotoplak
Copy link
Member

@mitjapotocin, thanks. I fixed sorting (operation priority was the problem). Merging.

@markotoplak markotoplak merged commit 043c6ec into main Dec 18, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants