Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] application.py: Fix qt plugins search logic error #311

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Wrong logic in fix_qt_plugins_path

Was broken for PyQt5 due to early return

Changes

Fix qt plugins search logic error

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (35d517f) to head (1b341a6).

Files with missing lines Patch % Lines
orangecanvas/application/application.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         100      100           
  Lines       21214    21214           
=======================================
  Hits        16253    16253           
  Misses       4961     4961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd janezd merged commit bad9db8 into biolab:master Oct 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants