-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] read/write: (Un)pickle only on user confirmation #127
base: master
Are you sure you want to change the base?
[FIX] read/write: (Un)pickle only on user confirmation #127
Conversation
@@ -804,16 +1006,16 @@ def check(obj): | |||
return all(map(check, obj)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ales-erjavec, on Friday I didn't yet realize that .ows files contain literals, not json. I am always a few (well, a many) steps behind. :|
The list of allowed sequences does not include sets. I suppose it's because there's no literal for an empty set. But could non-empty sets be allowed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It would need to be all sets or none at all.
a69c669
to
a11e98a
Compare
a11e98a
to
ff42430
Compare
ff42430
to
28847dd
Compare
Issue
Pickle format is used in the serialization (as a fallback when parameters cannot be saved as a python literal).
Changes
When saving: warn and ask for confirmation when the saved workflow will contain unsafe content.
When loading: warn and ask for confirmation; optionally load only workflow structure without parameters.