Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] read/write: (Un)pickle only on user confirmation #127

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Pickle format is used in the serialization (as a fallback when parameters cannot be saved as a python literal).

Changes

  • When saving: warn and ask for confirmation when the saved workflow will contain unsafe content.

  • When loading: warn and ask for confirmation; optionally load only workflow structure without parameters.

@janezd
Copy link
Contributor

janezd commented Sep 25, 2020

@@ -804,16 +1006,16 @@ def check(obj):
return all(map(check, obj))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ales-erjavec, on Friday I didn't yet realize that .ows files contain literals, not json. I am always a few (well, a many) steps behind. :|

The list of allowed sequences does not include sets. I suppose it's because there's no literal for an empty set. But could non-empty sets be allowed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It would need to be all sets or none at all.

@ales-erjavec ales-erjavec force-pushed the readwrite-pickle-only-on-confirmation branch from a69c669 to a11e98a Compare January 4, 2021 10:07
@ales-erjavec ales-erjavec force-pushed the readwrite-pickle-only-on-confirmation branch from a11e98a to ff42430 Compare February 17, 2021 11:08
@ales-erjavec ales-erjavec force-pushed the readwrite-pickle-only-on-confirmation branch from ff42430 to 28847dd Compare August 20, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants