[fix] ensure gcc 4.8 compat header is installed #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 28 28
Lines 3099 3099
=======================================
Hits 3005 3005
Misses 94 94 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The failures are from clang with visual studio, and not related with this PR. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #103
This duplicates the gcc 4.8 compat header. It's a good-enough trade-off for the fact that it needs to be installed, and not having
c4_add_target()add the include dir. The header contents are stable enough to withstand the duplication from the cmake project (which is needed because gtest does not compile on 4.8 without this header being injected with-include).