Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nanosim build #51084

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Bump nanosim build #51084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions recipes/nanosim/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ set -eu -o pipefail

mkdir -p ${PREFIX}/bin
cp -rf src/*.py ${PREFIX}/bin/
cp -rf src/*lua ${PREFIX}/bin/

chmod 0755 "${PREFIX}/bin/read_analysis.py"
chmod 0755 "${PREFIX}/bin/simulator.py"
2 changes: 1 addition & 1 deletion recipes/nanosim/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ source:

build:
noarch: generic
number: 0
number: 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Issue Detected: src/ Directory Missing in build.sh

The build.sh script references a src/ directory (recipes/nanosim/src/), but no such directory exists in the repository. This discrepancy may prevent necessary files from being copied during the build process, potentially leading to build failures or missing functionalities.

Please verify the location of the source files and update the build.sh script accordingly to ensure all necessary files are included in the build.

🔗 Analysis chain

LGTM: Build number increment is appropriate.

The build number increment from 0 to 1 is correct and aligns with the Conda packaging best practices. This change suggests modifications to the package that don't warrant a version change, which is consistent with the PR objective of including a missing file for certain modes of the NanoSim tool.

To ensure the PR objective is met, please verify that the missing file is indeed included in the new build. You can do this by examining the build.sh script (which should be in the same directory as this meta.yaml file) for any changes related to file copying or installation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for changes in the build.sh file
cat recipes/nanosim/build.sh

Length of output: 233

Script:

#!/bin/bash
# List all files in the src directory to verify inclusion of the missing file
ls -la recipes/nanosim/src/

Length of output: 97

Script:

#!/bin/bash
# Find all src directories in the repository
find . -type d -name "src"

Length of output: 26

run_exports:
- {{ pin_subpackage('nanosim', max_pin="x") }}

Expand Down