-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bx-python to 0.12, fix pypi url #49231
Conversation
Unclear why osx fails - nothing useful in logs - maybe OOM?
I just reran and then it worked. |
Happy to be added as maintainer. I can have a look when I am back at my laptop. |
9d4efcc
to
d6fcbe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a way to build it also for Python 3.8.
The bx_python-0.12.0.tar.gz
sdist from PyPI contains C files built with Cython and numpy 2.0, so it's possible to install it with numpy >=1.25 (the oldest numpy release to support Python 3.9).
When using an older numpy (as in the Python 3.8 builds), gcc will consider -Wimplicit-function-declaration
and -Wint-conversion
as warnings and install bx-python 0.12.0 fine, while clang>=16 considers them errors and fails the build.
The solution is to force-rebuild the C files with Cython when building for Python <3.9.
Thanks @corneliusroemer ! |
Great job - thanks @nsoranzo! |
* f bx-python * reset build number to 0 * fix deps * disable py38 build * [skip ci] add nsoranzo to maintainer list * Drop unnecessary wheel host requirement * Try to restore py38 build --------- Co-authored-by: Nicola Soranzo <[email protected]>
Autobump didn't work because of changed pypi source file path, see #48971
For reviewers
I disabled python 3.8 builds because the build errored with python 3.8
You can see the failing build here: https://app.circleci.com/pipelines/github/bioconda/bioconda-recipes/122485/workflows/1586943a-0729-439c-9c87-1c2bc52eecbd/jobs/196844?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
As the recipe has no maintainers (volunteers come forward please!) I requested reviews from bx-python contributors who are also members of bioconda. Maybe you know how to get 0.12 to work with py38.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.