Skip to content

Commit

Permalink
Update short-read-connector to v1.2.0 (#41567)
Browse files Browse the repository at this point in the history
* Update short-read-connector to v1.2.0

 * Change source URL to GitHub, INRIA server from v1.1.3 not reachable
 * Add C++ compiler dependency for build
 * Main shell script name has changed, update build.sh and tests
 * Use abbreviation for license; add license_family field

* Remove short-read-connector from build blacklist

No longer failing when tested locally

* Change name to match folder; specify license file

* Skip build for OS X

Skip OS X for now because build test failing, see
GATB/short_read_connector#6

---------

Co-authored-by: Silas Kieser <[email protected]>
  • Loading branch information
kbseah and SilasK authored Jun 20, 2023
1 parent 7e7c7ad commit 22889d6
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 15 deletions.
3 changes: 0 additions & 3 deletions build-fail-blacklist
Original file line number Diff line number Diff line change
Expand Up @@ -578,9 +578,6 @@ recipes/genblasta
# ImportError: cannot import name 'aveQual'
recipes/nanosplit

# ../short_read_connector.sh: line 299: /opt/conda/conda-bld/shortreadconnector_1531045819227/work/build/bin/SRC_linker_ram: No such file or directory
recipes/short-read-connector

# Cpp no such file or dir
recipes/genepop

Expand Down
21 changes: 16 additions & 5 deletions recipes/short-read-connector/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,31 @@ sed -i.bak 's/make -j/make -j1/' INSTALL
sed -i.bak 's/2> log_linker_err//' test/simple_test.sh

# change run_discoSnp++.sh deps path
sed -i.bak 's|\$EDIR/bin|\$EDIR|' short_read_connector.sh
sed -i.bak 's|\$EDIR/bin|\$EDIR|' short_read_connector_linker.sh
sed -i.bak 's|\$EDIR/bin|\$EDIR|' short_read_connector_counter.sh

# remove precompiled binary for dsk
sed -i.bak 's|\$EDIR/thirdparty/dsk/bin/linux/dsk|dsk|' short_read_connector.sh
sed -i.bak 's|\$EDIR/thirdparty/dsk/bin/macosx/dsk|dsk|' short_read_connector.sh
sed -i.bak 's|\$EDIR/thirdparty/dsk/bin/linux/dsk|dsk|' short_read_connector_linker.sh
sed -i.bak 's|\$EDIR/thirdparty/dsk/bin/macosx/dsk|dsk|' short_read_connector_linker.sh
# comment out chmod command for precompiled binary for dsk
sed -i.bak 's/^chmod/# chmod/' short_read_connector_linker.sh

# remove precompiled binary for dsk
sed -i.bak 's|\$EDIR/thirdparty/dsk/bin/linux/dsk|dsk|' short_read_connector_counter.sh
sed -i.bak 's|\$EDIR/thirdparty/dsk/bin/macosx/dsk|dsk|' short_read_connector_counter.sh
# comment out chmod command for precompiled binary for dsk
sed -i.bak 's/^chmod/# chmod/' short_read_connector_counter.sh

# installation
sh INSTALL

# copy binaries
cp short_read_connector.sh ${PREFIX}/bin
cp short_read_connector_counter.sh ${PREFIX}/bin
cp short_read_connector_linker.sh ${PREFIX}/bin

# apply permissions for pipeline
chmod +x ${PREFIX}/bin/short_read_connector.sh
chmod +x ${PREFIX}/bin/short_read_connector_linker.sh
chmod +x ${PREFIX}/bin/short_read_connector_counter.sh

# copy external bin
cp build/bin/* ${PREFIX}/bin
21 changes: 14 additions & 7 deletions recipes/short-read-connector/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
package:
name: shortreadconnector
version: '1.1.3'
name: short-read-connector
version: '1.2.0'

source:
url: "http://gatb-tools.gforge.inria.fr/ci-inria/rconnector-v1.1.3-Source.tar.gz"
md5: "dfb9ea38a562df02c5046574d1bba1bb"
url: "https://github.com/GATB/short_read_connector/releases/download/v1.2.0/rconnector-v1.2.0-Source.tar.gz"
md5: "2b7a3c9bdb5a3d3e2d3c9fdd9b496323"

build:
number: 2
number: 0
skip: True # [osx]

requirements:
build:
- make
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- cmake
host:
- zlib
Expand All @@ -22,9 +24,14 @@ requirements:
- dsk
test:
commands:
- short_read_connector.sh -h
- short_read_connector_linker.sh index -h
- short_read_connector_linker.sh query -h
- short_read_connector_counter.sh index -h
- short_read_connector_counter.sh query -h

about:
home: https://github.com/GATB/short_read_connector
license: GNU Affero General Public License v3.0
license: AGPL-3.0
license_family: AGPL
license_file: LICENSE
summary: Short read connector enables the comparisons of two read sets

0 comments on commit 22889d6

Please sign in to comment.