ci: incorporate more style check and package build elements from Biocommons template #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
reviewed
Sep 18, 2023
| name: Bug report | ||
| about: Create a report to help us improve | ||
| title: '' | ||
| labels: '' |
There was a problem hiding this comment.
Suggested change
| labels: '' | |
| labels: 'bug' |
| A clear and concise description of what you expected to happen. | ||
|
|
||
| **Additional context** | ||
| Add any other context about the problem here. |
There was a problem hiding this comment.
Do we want to do the thing where they confirm "yes i've checked that an issue does not already exist"
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: '' |
There was a problem hiding this comment.
Suggested change
| labels: '' | |
| labels: 'enhancement' |
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.10" |
There was a problem hiding this comment.
We should use the python matrix for other versions
|
@korikuzma I'm a little hesitant to introduce more differences between this and the template? or maybe it doesn't matter tbh |
korikuzma
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #23
Includes a
blackrun, so lots of annoying diffs. Also moves more things over topyproject.toml. Adds some GitHub cookie cutter things.