Allow setting MaxPaths, EcmpOnly and BestOnly for ObserveRIB request #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves github.com/bio-routing/issues/466 for the ris server part. Signed-off-by: netixx <[email protected]>
netixx
force-pushed
the
feat/observe-rib-options
branch
from
d81232a to
c76016b
Compare
|
Something looks wrong with the codecov action atm... |
taktv6
reviewed
Jul 21, 2024
| @@ -58,6 +65,7 @@ message ObserveRIBRequest { | |||
| } | |||
| AFISAFI afisafi = 3; | |||
| bool allow_unready_rib = 5; | |||
| optional ObserveRIBOptions observe_options = 6; // additional options for the observe request | |||
There was a problem hiding this comment.
Is there a reason you're just not extending the ObserveRIBRequest instead of defining another message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves github.com//issues/466 for the ris server part.