bnet.IP.String() should be called by value (#386)

Signed-off-by: Maximilian Wilhelm <[email protected]>
bio-routing · Sep 15, 2022 · 32000ff · 32000ff
1 parent df4fc63
commit 32000ff
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/net/ip.go b/net/ip.go
@@ -174,15 +174,15 @@ func (ip *IP) Compare(other *IP) int8 {
 }
 
 // String returns string representation of an IP address
-func (ip *IP) String() string {
+func (ip IP) String() string {
 	if !ip.isLegacy {
 		return ip.stringIPv6()
 	}
 
 	return ip.stringIPv4()
 }
 
-func (ip *IP) stringIPv6() string {
+func (ip IP) stringIPv6() string {
 	return fmt.Sprintf("%X:%X:%X:%X:%X:%X:%X:%X",
 		ip.higher&0xFFFF000000000000>>48,
 		ip.higher&0x0000FFFF00000000>>32,
@@ -194,7 +194,7 @@ func (ip *IP) stringIPv6() string {
 		ip.lower&0x000000000000FFFF)
 }
 
-func (ip *IP) stringIPv4() string {
+func (ip IP) stringIPv4() string {
 	b := ip.Bytes()
 
 	return fmt.Sprintf("%d.%d.%d.%d", b[0], b[1], b[2], b[3])