Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 'dev' into 'main' #8

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Merge 'dev' into 'main' #8

merged 5 commits into from
Jun 23, 2023

Conversation

vinisalazar
Copy link
Member

@vinisalazar vinisalazar commented May 23, 2022 •
edited
Loading

Summary of changes:

Tests passing ATM.

@vinisalazar
Add param 'fmt' to function 'download_griddap_dataset'
a78789e
@vinisalazar
Rename function 'download_griddap_dataset' to 'download_dataset'
f66575d 
  Since we're only using griddap datasets, I thought it may be easier to use a mmore general function name.
@vinisalazar
Cleanup: rename file and update tests
9cf3afa 
  - Rename draft.R to main.R
  - Refactor 'download_griddap_dataset' as 'download_dataset' in tests and man
  - Update tests
    - Test CSV response
@vinisalazar vinisalazar requested a review from salvafern May 23, 2022 07:39
@salvafern
Copy link
Member

Damn I overlooked this, I'm really sorry!
Merging immediately.
I got some other ideas for the list_layers() fun, but will discuss in a separate PR.

@salvafern salvafern merged commit 4e92f69 into bio-oracle:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salvafern salvafern Awaiting requested review from salvafern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinisalazar @salvafern