Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shell.nix #175

Merged
merged 8 commits into from
Dec 13, 2024
Merged

add shell.nix #175

merged 8 commits into from
Dec 13, 2024

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Sep 4, 2024

add a shell.nix for development on try in a Nix environment.

@ezrizhu ezrizhu requested a review from mgree September 4, 2024 22:35
@ezrizhu ezrizhu self-assigned this Sep 4, 2024
@mgree
Copy link
Contributor

mgree commented Sep 5, 2024

Can we add a CI task that tests it out?

@ezrizhu
Copy link
Collaborator Author

ezrizhu commented Nov 2, 2024 •
edited
Loading

Can we add a CI task that tests it out?

Done, we're currently excluding two tests.

mgree
mgree requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per convo on discord: let's actually fix the tests rather than leaving them as issues. Once you let things slide a bit, they tend to slide a lot more.

@ezrizhu ezrizhu requested a review from mgree December 13, 2024 02:34
@mgree mgree merged commit f938e2a into main Dec 13, 2024
23 checks passed
@mgree mgree deleted the nix branch December 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgree mgree Awaiting requested review from mgree

Assignees

@ezrizhu ezrizhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezrizhu @mgree