Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double exit bug in parallel pipelines #739

Open
wants to merge 4 commits into
base: future
Choose a base branch
from
Open

Fix double exit bug in parallel pipelines #739

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70073db
Fix double-exit bug in parallel pipelines
BolunThompson Dec 29, 2024
509fcf0
Assert running_procs is positive
BolunThompson Dec 29, 2024
07b09be
Fix: don't use exit handler
BolunThompson Dec 29, 2024
ad1062a
Add comment explanation
BolunThompson Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/pash_compilation_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ def remove_process(self, process_id):
]
)

assert self.running_procs > 0
self.running_procs -= 1
if self.running_procs == 0:
self.unsafe_running = False
Expand Down
2 changes: 1 addition & 1 deletion compiler/pash_runtime.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ else
pash_redir_output echo "$$: (5) BaSh script exited with ec: $pash_runtime_final_status"
else
function run_parallel() {
trap inform_daemon_exit SIGTERM SIGINT EXIT
trap inform_daemon_exit SIGTERM SIGINT
export SCRIPT_TO_EXECUTE="$pash_script_to_execute"
source "$RUNTIME_DIR/pash_restore_state_and_execute.sh"
inform_daemon_exit
BolunThompson marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading