Increment version #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bolun Thompson <[email protected]>
|
Actually, there is an additional problem, that currently we can't even deploy to PyPI with the current workflow. If you could debug and figure out how to properly build it (and test using a testPyPI repository), that would be great! I would look at the workflow here to get started (https://github.com/binpash/libdash/blob/master/.github/workflows/build.yml) because libdash also has binary distributions. No worries if you can't do it, I will take a look once I have more time. You might need to experiment on a local branch of yours (where you also add secret TestPyPI token to be able to push to the repo. Then we can merge to this one here. |
|
Done in #4. I now know a lot more about python packaging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.