Add "ADDITIONAL_PKGS" env var to Jenkins template #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@binhex any feedback on this? we may actually be able to remove the deps for openssh and git in the future and rely on this feature for that instead (as not everyone will need Git on their Jenkins container?) |
|
Hi sorry for the delay, I agree that the ability to specify additional packages should be included, however I want to add this functionality to multiple images so I'm going to have a little think about this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds the environment variable ADDITIONAL_PKGS to the Jenkins template. Space-separated list allows container maintainers to specify additional packages to be installed for Jenkins. Specifically for my needs, I need NPM installed to perform builds (no benefit from setting up separate instances of Jenkins, very barebones use case)