Skip to content
This repository has been archived by the owner on May 21, 2020. It is now read-only.

Hybrid: default+installer #7

Merged
merged 24 commits into from
May 8, 2019
Merged

Hybrid: default+installer #7

merged 24 commits into from
May 8, 2019

Conversation

Croydon
Copy link
Member

@Croydon Croydon commented Apr 28, 2019

Based on what @SSE4 has done with Bison and what @uilianries with Thrift, I have tried to adopt the same structure for Flex

This is an alternative suggestion for #4 & #5 which is cleaner in my opinion

I could need a little help with getting the installer done. It currently fails with

CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/conan/.conan/data/flex_installer/2.6.4/bincrafters/croydon/build/445cf80f611c1d1eda08bde2ebc5066218ca9701/source_subfolder/build-aux/missing aclocal-1.15 -I m4
/home/conan/.conan/data/flex_installer/2.6.4/bincrafters/croydon/build/445cf80f611c1d1eda08bde2ebc5066218ca9701/source_subfolder/build-aux/missing: line 81: aclocal-1.15: command not found
WARNING: 'aclocal-1.15' is missing on your system.
         You should only need it if you modified 'acinclude.m4' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'aclocal' program is part of the GNU Automake package:
         <http://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <http://www.gnu.org/software/autoconf>
         <http://www.gnu.org/software/m4/>
         <http://www.perl.org/>
make: *** [Makefile:493: aclocal.m4] Error 127

https://travis-ci.com/bincrafters/conan-flex/jobs/196178631#L841

PS: Thanks for playing around with different styles @madebr, since this is a new structure it is important to experiment a little and not settle for the very first idea

test_package based on work of @madebr

general structure based on the work of @SSE4 and @uilianries
Otherwise download instruction for the installer pacakge may break due to a different name.

_base_name is the same for default + installer and therefore reliable
@Croydon Croydon self-assigned this Apr 28, 2019
@Croydon Croydon requested review from SSE4 and uilianries April 28, 2019 19:58
@uilianries
Copy link
Member

I've started the same idea here: https://github.com/uilianries/conan-flex-bincrafters/tree/testing/2.6.4

But I think we could use your PR instead.

conanfile_installer.py Outdated Show resolved Hide resolved
@SSE4
Copy link
Member

SSE4 commented Apr 29, 2019

I agree we can merge for now
I have two local patches to fix CI, hopefully will have them landed tomorrow, one is simply to include MinGW patches only for Windows, second one is to resolve hang in stage1flex

build.py Outdated Show resolved Hide resolved
conanfile_base.py Outdated Show resolved Hide resolved
conanfile_base.py Outdated Show resolved Hide resolved
@madebr
Copy link

madebr commented Apr 30, 2019

Cross builing flex/2.6.4 for arm won't work because the stage1flex (built for arm) cannot run on x86.
The stage1flex binary needs to be built for the native architecture.

Add the following lines to .travis.yml to test my hypothesis:

      - <<: *linux
        env: CONAN_GCC_VERSIONS=8 CONAN_DOCKER_IMAGE=conanio/gcc8-armv8

@SSE4
Copy link
Member

SSE4 commented Apr 30, 2019

@madebr thanks for the note, I'll check this use-case tomorrow

@Croydon

This comment has been minimized.

@SSE4

This comment has been minimized.

@SSE4

This comment has been minimized.

@SSE4

This comment has been minimized.

@Croydon
Copy link
Member Author

Croydon commented May 8, 2019

Awesome work! 🎉

@Croydon Croydon merged commit 5aeaddf into testing/2.6.4 May 8, 2019
@SSE4 SSE4 deleted the croydon/2.6.4 branch May 10, 2019 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants