This repository has been archived by the owner on May 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_package based on work of @madebr general structure based on the work of @SSE4 and @uilianries
Otherwise download instruction for the installer pacakge may break due to a different name. _base_name is the same for default + installer and therefore reliable
I've started the same idea here: https://github.com/uilianries/conan-flex-bincrafters/tree/testing/2.6.4 But I think we could use your PR instead. |
uilianries
reviewed
Apr 29, 2019
uilianries
reviewed
Apr 29, 2019
uilianries
reviewed
Apr 29, 2019
uilianries
reviewed
Apr 29, 2019
I agree we can merge for now |
This was referenced Apr 30, 2019
uilianries
reviewed
Apr 30, 2019
uilianries
reviewed
Apr 30, 2019
uilianries
reviewed
Apr 30, 2019
Signed-off-by: SSE4 <[email protected]>
Co-Authored-By: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
uilianries
reviewed
Apr 30, 2019
uilianries
reviewed
Apr 30, 2019
uilianries
reviewed
Apr 30, 2019
Co-Authored-By: SSE4 <[email protected]>
Co-Authored-By: SSE4 <[email protected]>
Cross builing flex/2.6.4 for arm won't work because the Add the following lines to
|
@madebr thanks for the note, I'll check this use-case tomorrow |
Signed-off-by: SSE4 <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
Signed-off-by: SSE4 <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Awesome work! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on what @SSE4 has done with Bison and what @uilianries with Thrift, I have tried to adopt the same structure for Flex
This is an alternative suggestion for #4 & #5 which is cleaner in my opinion
I could need a little help with getting the installer done. It currently fails with
https://travis-ci.com/bincrafters/conan-flex/jobs/196178631#L841
PS: Thanks for playing around with different styles @madebr, since this is a new structure it is important to experiment a little and not settle for the very first idea