Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #667 - Remove credits filter from aws budget #668

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

martingaleano
Copy link
Contributor

What?

  • Remove credits filter from aws budget

Why?

  • The AWS budget takes the applied credits into account; therefore, the forecasted value is not entirely accurate.

References

  # module.aws_cost_mgmt_budget_notif_75.aws_budgets_budget.budget_notifification will be updated in-place
  ~ resource "aws_budgets_budget" "budget_notifification" {
        id                = "754065527950:budget-MONTHLY-root-75-percent"
        name              = "budget-MONTHLY-root-75-percent"
        # (9 unchanged attributes hidden)

      ~ cost_types {
          ~ include_credit             = true -> false
            # (10 unchanged attributes hidden)
        }

        # (1 unchanged block hidden)
    }


  # module.aws_cost_mgmt_budget_notif_100.aws_budgets_budget.budget_notifification will be updated in-place
  ~ resource "aws_budgets_budget" "budget_notifification" {
        id                = "754065527950:budget-MONTHLY-root-100-percent"
        name              = "budget-MONTHLY-root-100-percent"
        # (9 unchanged attributes hidden)

      ~ cost_types {
          ~ include_credit             = true -> false
            # (10 unchanged attributes hidden)
        }

        # (1 unchanged block hidden)
    }

@martingaleano martingaleano requested a review from a team as a code owner December 6, 2024 13:49
@martingaleano martingaleano requested a review from a team December 6, 2024 13:49
Copy link

github-actions bot commented Dec 6, 2024

💰 Infracost report

Monthly estimate generated

Estimate details (includes details of unsupported resources and skipped projects due to errors)
──────────────────────────────────
132 projects have no cost estimate changes.
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code

──────────────────────────────────
2598 cloud resources were detected:
∙ 596 were estimated
∙ 1881 were free
∙ 121 are not supported yet, see https://infracost.io/requested-resources:
  ∙ 45 x aws_identitystore_group_membership
  ∙ 37 x aws_identitystore_user
  ∙ 10 x aws_guardduty_member
  ∙ 7 x aws_identitystore_group
  ∙ 5 x aws_fms_policy
  ∙ 4 x aws_guardduty_detector
  ∙ 2 x aws_guardduty_organization_admin_account
  ∙ 2 x aws_guardduty_organization_configuration
  ∙ 2 x aws_organizations_delegated_administrator
  ∙ 1 x aws_cloudtrail_organization_delegated_admin_account
  ∙ 1 x aws_eks_access_entry
  ∙ 1 x aws_fms_admin_account
  ∙ 1 x aws_organizations_organization
  ∙ 1 x aws_route53_resolver_firewall_domain_list
  ∙ 1 x aws_route53_resolver_firewall_rule
  ∙ 1 x aws_route53_resolver_firewall_rule_group
This comment will be updated when code changes.

@martingaleano martingaleano merged commit e106b28 into master Dec 9, 2024
6 checks passed
@exequielrafaela exequielrafaela added enhancement New feature or request patch labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants