Bug/compatibility with rails 7.1 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First run failed with the following error: |
|
Github actions are passing in my personal repo: https://github.com/msuliq/authlogic/actions/runs/7217526649 |
tiegz
reviewed
Dec 16, 2023
CHANGELOG.md
Outdated
Comment on lines
24
to
25
| * [#768](https://github.com/binarylogic/authlogic/issues/768) - Fixed | ||
| compatibility issues with Rails 7.1 |
There was a problem hiding this comment.
Suggested change
| * [#768](https://github.com/binarylogic/authlogic/issues/768) - Fixed | |
| compatibility issues with Rails 7.1 | |
| * [#769](https://github.com/binarylogic/authlogic/issues/769) - Fixed GH workflow |
lib/authlogic/version.rb
Outdated
| @@ -17,6 +17,6 @@ module Authlogic | |||
| # | |||
| # @api public | |||
| def self.gem_version | |||
| ::Gem::Version.new("6.4.2") | |||
| ::Gem::Version.new("6.4.3") | |||
There was a problem hiding this comment.
I'll probably cut the version in a separate commit:
Suggested change
| ::Gem::Version.new("6.4.3") |
There was a problem hiding this comment.
Removed version bump from my PR
tiegz
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gem has compatibility issues with Rails 7.1 described here.
What has been implemented:
default_timezonedepending on rails versionExpected outcome
Should be possible to install and use Authlogic with Rails 7.1