Skip to content

Commit

Permalink
devtools: remove artificial limit on suggestion box width
Browse files Browse the repository at this point in the history
This was probably added in the stone ages when displays were 640x480px
For a while this setting was ignored because .suggest-box had
flex-box applied. With 06f5e50 it became
effective again.

My screen has 5120px width, no need to limit suggestion box to 300px.
I think it should be responsibility of the code feeding suggestion box's
items to trim their length reasonably (because that code understands them).
CSS's `overflow:hidden` is not helpful much in pathological cases of long items.
Better to leave suggest-box overgrow screen than hide its content IMO.

@JoelEinbinder ^
  • Loading branch information
darwin committed Oct 15, 2016
1 parent e722545 commit 824c29c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion resources/unpacked/devtools/front_end/ui/suggestBox.css
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
display: flex;
flex-direction: column;
flex: 0 0 auto;
max-width: 300px;
}

.suggest-box-top-spacer {
Expand Down

1 comment on commit 824c29c

@JoelEinbinder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll look into why it was there and if there was any reason for it.

Please sign in to comment.