Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Conversation

utkarsha-deriv
Copy link
Contributor

@utkarsha-deriv utkarsha-deriv commented Dec 11, 2023

This PR links the api call names inside the description of a given call. Upon clicking a particular keyword which is basically an api call name, the page re-renders and loads the description page of that api call name.

Screenshot 2023-12-11 at 5 49 48 PM

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-api-docs ✅ Ready (Inspect) Visit Preview Dec 14, 2023 9:33am

@utkarsha-deriv utkarsha-deriv changed the title feat: add to link api call names in description - generalise [API]/DEAR-450/add to link api call names in description - generalise Dec 11, 2023
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@utkarsha-deriv utkarsha-deriv changed the title [API]/DEAR-450/add to link api call names in description - generalise [API] add link TO api call names in description Dec 11, 2023
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@utkarsha-deriv utkarsha-deriv changed the title [API] add link TO api call names in description [API] add link to api call names in description Dec 11, 2023
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@utkarsha-deriv utkarsha-deriv marked this pull request as draft December 11, 2023 13:50
@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 7206966819

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.438%

Totals Coverage Status
Change from base Build 7193211538: 0.005%
Covered Lines: 1654
Relevant Lines: 1661

💛 - Coveralls

sanjam-deriv
sanjam-deriv previously approved these changes Dec 12, 2023
matin-deriv
matin-deriv previously approved these changes Dec 13, 2023
@sanjam-deriv sanjam-deriv merged commit 5b99240 into binary-com:master Dec 15, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants