-
Notifications
You must be signed in to change notification settings - Fork 31
Jim/FEQ-703/convert-circleci-config-on-deriv-api-docs-to-github-workflow #250
Jim/FEQ-703/convert-circleci-config-on-deriv-api-docs-to-github-workflow #250
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 122 122
Lines 1727 1727
Branches 230 230
=======================================
Hits 1691 1691
Misses 1 1
Partials 35 35 |
This reverts commit 7e76341.
…into Jim/FEQ-703/convert-circleci-config-on-deriv-api-docs-to-github-workflow
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | e8310d1 | config/v3/authorize/example.json | View secret |
- | Generic High Entropy Secret | e8310d1 | config/v3/authorize/example.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Changes:
Removed
secrets
andenvironment variables
below as I believe they were no longer in use:DOCKERHUB_ORGANISATION
DOCKERHUB_PASSWORD
DOCKERHUB_USERNAME
KUBE_SERVER
CA_CRT
DOCKHUB_ORGANISATION
SERVICEACCOUNT_TOKEN
CONTEXT_ARTIFACT_S3_BUCKET
DATADOG_APPLICATION_ID
DATADOG_CLIENT_TOKEN
Added new files to replace the old
circleci
configuration:.github/actions/build/action.yml
.github/actions/notify_slack/action.yml
.github/actions/npm_install_from_cache/action.yml
.github/actions/npm_install_from_cache/action.yml
.github/actions/publish_to_pages_production/action.yml
.github/actions/publish_to_pages_staging/action.yml
.github/actions/setup_node/action.yml
.github/actions/versioning/action.yml
.github/workflows/release_production.yml
.github/workflows/release_staging.yml