Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Conversation

jim-deriv
Copy link
Contributor

@jim-deriv jim-deriv commented Oct 4, 2023

Changes:

  • Removed secrets and environment variables below as I believe they were no longer in use:

    • DOCKERHUB_ORGANISATION
    • DOCKERHUB_PASSWORD
    • DOCKERHUB_USERNAME
    • KUBE_SERVER
    • CA_CRT
    • DOCKHUB_ORGANISATION
    • SERVICEACCOUNT_TOKEN
    • CONTEXT_ARTIFACT_S3_BUCKET
    • DATADOG_APPLICATION_ID
    • DATADOG_CLIENT_TOKEN

Added new files to replace the old circleci configuration:

  • .github/actions/build/action.yml
  • .github/actions/notify_slack/action.yml
  • .github/actions/npm_install_from_cache/action.yml
  • .github/actions/npm_install_from_cache/action.yml
  • .github/actions/publish_to_pages_production/action.yml
  • .github/actions/publish_to_pages_staging/action.yml
  • .github/actions/setup_node/action.yml
  • .github/actions/versioning/action.yml
  • .github/workflows/release_production.yml
  • .github/workflows/release_staging.yml

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-api-docs ✅ Ready (Inspect) Visit Preview Oct 12, 2023 5:06am

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #250 (7bd1f9f) into master (3a6ff98) will not change coverage.
The diff coverage is n/a.

❗ Current head 7bd1f9f differs from pull request most recent head 525b72f. Consider uploading reports for the commit 525b72f to get more accurate results

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files         122      122           
  Lines        1727     1727           
  Branches      230      230           
=======================================
  Hits         1691     1691           
  Misses          1        1           
  Partials       35       35           

.github/actions/invalidate_master_cache/action.yml Outdated Show resolved Hide resolved
.github/actions/invalidate_master_cache/action.yml Outdated Show resolved Hide resolved
.github/actions/invalidate_master_cache/action.yml Outdated Show resolved Hide resolved
.github/actions/npm_install_from_cache/action.yml Outdated Show resolved Hide resolved
.github/workflows/coveralls.yml Outdated Show resolved Hide resolved
.github/workflows/coveralls.yml Outdated Show resolved Hide resolved
@gitguardian
Copy link

gitguardian bot commented Oct 12, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret e8310d1 config/v3/authorize/example.json View secret
- Generic High Entropy Secret e8310d1 config/v3/authorize/example.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ali-hosseini-deriv ali-hosseini-deriv merged commit 716a52b into binary-com:master Oct 12, 2023
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants