Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close some issues #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Close some issues #59

wants to merge 3 commits into from

Conversation

Freed-Wu
Copy link

#52 and #54:
i recommend create another branch to handle overloaf temporarily. and other user use master. the problem that overloaf cannot support relative path, should be reported to developer of overloaf.

#53
not all latex engine define \XeLaTeX by default. hologo can make this command cross all latex engine.

thanks.

@billryan
Copy link
Owner

Thanks. A separate branch for overleaf sounds like a good idea. fontawesome5 is not supported by old TexLive distribution, this is the reason why I keep fontawesome package.

As you mentioned in #51, we can set adobe fonts and fontawesome optional to make this package clean.

I will use separate branch for overleaf and merge your PR later this weekend.

@Freed-Wu
Copy link
Author

Right, a new branch for different environment is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants