Allow configuring Redis connections via AsyncConnectionConfig #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikeshedder
reviewed
Sep 25, 2024
redis/src/lib.rs
Outdated
| /// # Errors | ||
| /// | ||
| /// If establishing a new [`Client`] fails. | ||
| pub fn new_with_connection_config<T: IntoConnectionInfo>( |
There was a problem hiding this comment.
I think I would like the name from_config or from_connection_config better for this. What do you think?
There was a problem hiding this comment.
from_config seemed more consistent with how things are named elsewhere, so I've changed it to that 👍
Louis-Tarvin
force-pushed
the
allow-configuring-redis-connections
branch
from
b436da1 to
6304ddd
Compare
This was referenced Dec 3, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, deadpool-redis doesn't provide any way to modify the
MultiplexedConnectionconfiguration (e.g. to set connection or response timeouts).This PR addresses this by implementing a new constructor for the
Manager,new_with_connection_config, that lets the user provide anAsyncConnectionConfigto theManager, such that we can construct the connection viaget_multiplexed_async_connection_with_config.Please let me know if there's anything I have missed or if you'd rather this be done differently.