Do not return an object value from a constructor. Fixes nodemailer#807

bijanmmarkes · Oct 11, 2017 · b889615 · b889615
1 parent 78e99a9
commit b889615
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/xoauth2/index.js b/lib/xoauth2/index.js
@@ -41,7 +41,8 @@ class XOAuth2 extends Stream {
 
         if (options && options.serviceClient) {
             if (!options.privateKey || !options.user) {
-                return setImmediate(() => this.emit('error', new Error('Options "privateKey" and "user" are required for service account!')));
+                setImmediate(() => this.emit('error', new Error('Options "privateKey" and "user" are required for service account!')));
+                return;
             }
 
             let serviceRequestTimeout = Math.min(Math.max(Number(this.options.serviceRequestTimeout) || 0, 0), 3600);
@@ -300,7 +301,10 @@ class XOAuth2 extends Stream {
      */
     jwtSignRS256(payload) {
         payload = ['{"alg":"RS256","typ":"JWT"}', JSON.stringify(payload)].map(val => this.toBase64URL(val)).join('.');
-        let signature = crypto.createSign('RSA-SHA256').update(payload).sign(this.options.privateKey);
+        let signature = crypto
+            .createSign('RSA-SHA256')
+            .update(payload)
+            .sign(this.options.privateKey);
         return payload + '.' + this.toBase64URL(signature);
     }
 }