Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace spaces by underscores in file names #24

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Replace spaces by underscores in file names #24

merged 7 commits into from
Jan 11, 2024

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Jan 10, 2024

Fixes #16.

mzur
mzur requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also replace spaces in directory names.

src/resources/assets/js/createContainer.vue Outdated Show resolved Hide resolved
src/resources/assets/js/createContainer.vue Outdated Show resolved Hide resolved
@lehecht lehecht requested a review from mzur January 11, 2024 07:20
mzur
mzur reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since the JS files were changed, npm run prod had to be executed and the public JS files committed, too. But I will do that myself here.

src/resources/views/create.blade.php Outdated Show resolved Hide resolved
@mzur mzur merged commit b1d3b79 into master Jan 11, 2024
2 checks passed
@mzur mzur deleted the spaces-in-filename-bug branch January 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzur mzur mzur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error copying object larger than 5 GB
2 participants
@lehecht @mzur