Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #242 #495

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alisoncallahan
Copy link
Contributor

@alisoncallahan alisoncallahan commented Apr 20, 2022

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.

If the following information is NOT present in the issue, please populate:

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@hakunanatasha
Copy link
Collaborator

@alisoncallahan let us know if you need help with this!

@alisoncallahan
Copy link
Contributor Author

thanks @hakunanatasha, this is in progress. no blockers for now, except lack of time ;-) I'm working on it today and tomorrow.

…re is some weirdness with text offsets and how special characters are rendered (I think), so tests do not pass.
@alisoncallahan
Copy link
Contributor Author

@jason-fries @hakunanatasha committed what I have so far. KB schema tests are failing because there is still weirdness in reconciling offsets with source text.

@ruisi-su
Copy link
Collaborator

hey, @alisoncallahan thanks for helping us with this dataset! I can confirm that both load_dataset and unit-test on source config are working. However, I did encounter the same failures when compiling against the tac2017_bigbio_kb config. Additionally, you could run the command below:

python -m tests.test_bigbio_by_name biodatasets/tac2017/tac2017.py tac2017_bigbio_kb

This seems to log more details than the other test command. Hope it helps. Please don't hesitate to reach out if you have further questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants