Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A method in SettingsPanel to programmatically show a specific existing page. #166

Merged
merged 4 commits into from
Oct 15, 2023
Merged

A method in SettingsPanel to programmatically show a specific existing page. #166

merged 4 commits into from
Oct 15, 2023

Conversation

tinevez
Copy link
Contributor

@tinevez tinevez commented Aug 21, 2023

No description provided.

@tpietzsch tpietzsch self-requested a review September 7, 2023 10:02
@tpietzsch tpietzsch self-assigned this Sep 7, 2023
tpietzsch
tpietzsch approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@tpietzsch tpietzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition. I modified it to move the path-to-treenode logic into a separate method (to avoid code duplication). And added some javadoc.

@tpietzsch tpietzsch merged commit c4ec970 into master Oct 15, 2023
1 check passed
@tpietzsch tpietzsch deleted the show-page branch October 15, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpietzsch tpietzsch tpietzsch approved these changes

Assignees

@tpietzsch tpietzsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinevez @tpietzsch