fix: fix variable init error (OpenAtomFoundation#2421)

* fix variable init error * fix by review comments --------- Co-authored-by: wangshaoyi <[email protected]>
bigdaronlee163 · Feb 27, 2024 · e4ad93e · e4ad93e
1 parent 5888cf5
commit e4ad93e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/include/pika_conf.h b/include/pika_conf.h
@@ -735,8 +735,8 @@ class PikaConf : public pstd::BaseConf {
   int max_cache_statistic_keys_ = 0;
   int small_compaction_threshold_ = 0;
   int small_compaction_duration_threshold_ = 0;
-  int max_background_flushes_ = 0;
-  int max_background_compactions_ = 0;
+  int max_background_flushes_ = 1;
+  int max_background_compactions_ = 2;
   int max_background_jobs_ = 0;
   int max_cache_files_ = 0;
   std::atomic<uint64_t> rocksdb_ttl_second_ = 0;

diff --git a/src/pika_conf.cc b/src/pika_conf.cc
@@ -361,16 +361,14 @@ int PikaConf::Load() {
     small_compaction_duration_threshold_ = 1000000;
   }
 
-  max_background_flushes_ = 1;
   GetConfInt("max-background-flushes", &max_background_flushes_);
   if (max_background_flushes_ <= 0) {
     max_background_flushes_ = 1;
   }
-  if (max_background_flushes_ >= 4) {
-    max_background_flushes_ = 4;
+  if (max_background_flushes_ >= 6) {
+    max_background_flushes_ = 6;
   }
 
-  max_background_compactions_ = 2;
   GetConfInt("max-background-compactions", &max_background_compactions_);
   if (max_background_compactions_ <= 0) {
     max_background_compactions_ = 2;
@@ -379,13 +377,13 @@ int PikaConf::Load() {
     max_background_compactions_ = 8;
   }
 
-  max_background_jobs_ = (1 + 2);
+  max_background_jobs_ = max_background_flushes_ + max_background_compactions_;
   GetConfInt("max-background-jobs", &max_background_jobs_);
   if (max_background_jobs_ <= 0) {
     max_background_jobs_ = (1 + 2);
   }
-  if (max_background_jobs_ >= (8 + 4)) {
-    max_background_jobs_ = (8 + 4);
+  if (max_background_jobs_ >= (8 + 6)) {
+    max_background_jobs_ = (8 + 6);
   }
 
   max_cache_files_ = 5000;

diff --git a/src/storage/src/storage.cc b/src/storage/src/storage.cc
@@ -2269,7 +2269,7 @@ Status Storage::GetUsage(const std::string& property, uint64_t* const result) {
 Status Storage::GetUsage(const std::string& property, std::map<int, uint64_t>* const inst_result) {
   inst_result->clear();
   for (const auto& inst : insts_) {
-    uint64_t value;
+    uint64_t value = 0;
     inst->GetProperty(property, &value);
     (*inst_result)[inst->GetIndex()] = value;
   }