Fix getHeader to be case-insensitive #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On certain BigCommerce stores, getHeader fails because the X-BC-ApiLimit-Remaining header is all lower-case in the HTTP response. This causes getRequestsRemaining to always return 0 and puts the code into an infinite wait for more requests. Instead, change getHeader to do a case-insensitive search for the header if the exact case is not found. Please merge this into the trunk.
|
Hey, thanks for fixing this (again)! Can you take a look at the Travis failures? |
lord2800
approved these changes
Jan 10, 2019
lord2800
approved these changes
Jan 10, 2019
|
Travis was just complaining about spacing. I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On certain BigCommerce stores, getHeader fails because the X-BC-ApiLimit-Remaining header is all lower-case in the HTTP response. This causes getRequestsRemaining to always return 0 and puts the code into an infinite wait for more requests. Instead, change getHeader to do a case-insensitive search for the header if the exact case is not found. Please merge this into the trunk. The code keeps breaking every time I update the library.
I had created a previous pull request to fix this, but I don't think it got fixed:
#196