Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resource.php #132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Resource.php #132

wants to merge 3 commits into from

Conversation

sudosoul
Copy link

$fields should be public so you can access its individual members directly

$fields should be public so you can access its individual members directly
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.4% when pulling 0aa766b on mullinsr:patch-2 into 15aaf1b on bigcommerce:master.

Robert Mullins added 2 commits April 17, 2015 22:20
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 58.5% when pulling 43fb566 on mullinsr:patch-2 into 15aaf1b on bigcommerce:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 58.5% when pulling 43fb566 on mullinsr:patch-2 into 15aaf1b on bigcommerce:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 58.5% when pulling 43fb566 on mullinsr:patch-2 into 15aaf1b on bigcommerce:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 58.5% when pulling 43fb566 on mullinsr:patch-2 into 15aaf1b on bigcommerce:master.

@sudosoul
Copy link
Author

I added oAuth support on Client and Connection, so far it seems to be very stable with this new updated library (connection would intermittently drop on old oauth branch).
oAuth is configured by calling:

$array = array(
  'store_hash' => 'xxx',
  'client_id'     => 'xxx',
  'oauth_token' => 'xx'
);
Bigcommerce::configure($array,true);

My intentions for this pr was to bring up the protected fields issue. Feel free to modify oauth changes as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants