Partial Fix: Correctly display the discount percentage on Invoice Creation and discount fix on items #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue of displaying the correct percentage charachter at the creation of an invoice. Additionally, addreses a partial bug refered on the issue #556 where the Discount is not being properly applied on the invoices.
Changes:
Before:
After:
Was not able to fix the invoice ISaleInvoice assign in order to retrieve the discounts and properly dispay them on the frontend. Also, I'm not sure if there's another twerks to be made in order to completely fix the bug.
Keep up with the good work!