Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): replace eslint for biomejs with airbnb defaults imported #415

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

benpsnyder
Copy link
Contributor

I have spend two weekends, more than 15 hours each weekend, working on type safety and improvements to this repository.

In that time, I have seen tremendous inconsistency in formatting of files and conventions that has made it difficult to effect change easily throughout the repository. The most simple example of this is where require or import statements use both " and '

Examples
image
image

This PR achieves the following:

Before closing this PR, I request the following:

  • That @abouolia run pnpm run format and pnpm run lint and test and evaluate results
  • That you apply the new formatting across the thousands of files, and reformat this whole repo before closing this PR

There are tremendous benefits to be gained from using a rust-based formatting and linting which is super fast, along with the VS Code extension (recommended via .vscode/extensions.json).

Thanks

Copy link

vercel bot commented Apr 22, 2024

@benpsnyder is attempting to deploy a commit to the Bigcapital Team on Vercel.

A member of the Team first needs to authorize it.

@benpsnyder benpsnyder force-pushed the feat/replace-eslint-for-biomejs branch from b4ed7da to 4a79c06 Compare April 22, 2024 04:39
@benpsnyder
Copy link
Contributor Author

Also - worst case scenario, if you don't want to run the formatter/lint across the whole codebase in one go, I have included VSC settings that will run biomejs.biome as the default formatter, and on file save. So if you want to be ultra conservative, you can let it format over time.

I believe it to be quite safe to run the formatter all at once before closing this PR and it will bring more productivity to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant