Replace flake8/isort/black with ruff #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 634 632 -2
=========================================
- Hits 634 632 -2 ☔ View full report in Codecov by Sentry. |
sappelhoff
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Wonderful, this has been on my to do list for a long time. Thanks for taking this over @cbrnr.
Just a small comment why not do docs/ as well (but could be done in a follow up, so I am approving anyhow).
cbrnr
commented
Feb 11, 2024
| @@ -39,7 +39,7 @@ you can run tests by making use of the `Makefile` and | |||
| From the project root, call: | |||
|
|
|||
| - `make test` to run tests and coverage | |||
| - `make pep` to run style checks | |||
| - `pre-commit run` to run style checks (Ruff and some additional hooks) | |||
There was a problem hiding this comment.
Shouldn't this better be pre-commit run -a?
There was a problem hiding this comment.
Yes, otherwise it will only run against staged files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces flake8/isort/black with ruff. In addition, I've (mostly manually) re-formatted docstrings so that they now use the line length limit of 88 chars. I've also removed
make pep, because this is now being taken care of via pre-commit.