Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated mne.utils.requires_version #105

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

musicinmybrain
Copy link
Contributor

This function is deprecated and will be removed in a future release; see:

mne-tools/mne-python@84da555

Use the recommended replacement pytest.importorskip() instead.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (084379d) to head (dfa4786).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          633       632    -1     
=========================================
- Hits           633       632    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This function is deprecated and will be removed in a future release; see:

mne-tools/mne-python@84da555

Use the recommended replacement pytest.importorskip() instead.
@musicinmybrain
Copy link
Contributor Author

Moved the call to pytest.importorskip to the top of the test so less work is done when the test will be skipped.

@sappelhoff
Copy link
Member

Thanks @musicinmybrain for this PR and your other one! Could you please:

  • add yourself to CITATION.cff
  • figure out why the readthedocs job is failing?

I'll be able to engage more reliably with your two contributions in the next week.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@sappelhoff sappelhoff merged commit 35f4e8b into bids-standard:main Oct 4, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants