Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make lists and dicts hashable #1112

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

bpinsard
Copy link
Contributor

sets #684 up-to-date with master branch.

should fix #834

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (2c0469b) to head (234f624).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/bids/layout/layout.py 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1112   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files         130      130           
  Lines       14232    14278   +46     
  Branches     1672     1680    +8     
=======================================
+ Hits        12730    12772   +42     
- Misses       1104     1106    +2     
- Partials      398      400    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refreshing this!

@effigies effigies merged commit c66a4d9 into bids-standard:master Dec 13, 2024
24 checks passed
@bpinsard
Copy link
Contributor Author

4 years was a bit too old :D

Thanks for merging this fast!

@bpinsard bpinsard deleted the pr/684 branch December 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_B0FieldIdentifiers errors
3 participants