Skip to content

Commit

Permalink
FIX: Do not error when popping missing scan_length (#679)
Browse files Browse the repository at this point in the history
* FIX scanlength pop issue

* pin sqlalchemhy version

* Update setup.cfg

Co-authored-by: Chris Markiewicz <[email protected]>
  • Loading branch information
Shotgunosine and effigies authored Nov 9, 2020
1 parent 7440d48 commit 17db824
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bids/analysis/analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def setup(self, steps=None, drop_na=False, finalize=True, **kwargs):
step.add_collections(drop_na=drop_na, **selectors)

if finalize:
selectors.pop('scan_length') # see TODO below
selectors.pop('scan_length', None) # see TODO below
self.finalize(**selectors)

def finalize(self, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ install_requires =
nibabel >=2.1
pandas >=0.23
patsy
sqlalchemy
sqlalchemy <1.4.0.dev0
bids-validator
num2words
click
Expand Down

0 comments on commit 17db824

Please sign in to comment.