Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inheritance): Improve error definition for MULTIPLE_INHERITABLE_FILES #2155

Merged

Conversation

effigies
Copy link
Collaborator

Closes #2153.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (c52a671) to head (a2443cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2155      +/-   ##
==========================================
+ Coverage   85.73%   87.67%   +1.94%     
==========================================
  Files          91      133      +42     
  Lines        3785     7034    +3249     
  Branches     1220     1666     +446     
==========================================
+ Hits         3245     6167    +2922     
- Misses        454      772     +318     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the fix/multiple-inheritable-files-error branch from e9f9640 to 8fe0cc7 Compare October 10, 2024 19:52
@effigies effigies force-pushed the fix/multiple-inheritable-files-error branch from 8fe0cc7 to a2443cb Compare October 10, 2024 19:53
@rwblair rwblair merged commit 09222a7 into bids-standard:master Oct 10, 2024
19 checks passed
@effigies effigies deleted the fix/multiple-inheritable-files-error branch October 10, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: MULTIPLE_INHERITABLE_FILES should mention the problematic json files
2 participants