Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Parse bval/bvec files uniformly, add n_rows attribute to associations #1813

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

effigies
Copy link
Collaborator

This PR is paired with bids-standard/bids-specification#1622, which proposes augmenting the bval/bvec associations in the context.

This simplifies things a bit by using the same code to parse bvals and bvecs, ensuring that bugs found and fixed in one will work for the other.

@effigies effigies requested a review from rwblair September 28, 2023 19:35
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6789e4d) 85.58% compared to head (1f1cf20) 83.59%.

❗ Current head 1f1cf20 differs from pull request most recent head 0f273ff. Consider uploading reports for the commit 0f273ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
- Coverage   85.58%   83.59%   -1.99%     
==========================================
  Files         132       92      -40     
  Lines        6728     3895    -2833     
  Branches     1548     1272     -276     
==========================================
- Hits         5758     3256    -2502     
+ Misses        862      541     -321     
+ Partials      108       98      -10     

see 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit bd42250 into bids-standard:master Sep 28, 2023
18 of 22 checks passed
@effigies effigies deleted the enh/dwi-shape branch September 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants