Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : motion.json typo fix and remove unused fields #1791

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

sjeung
Copy link
Contributor

@sjeung sjeung commented Aug 25, 2023

  • Updated ´motion.json´ field MISChannelCount to MISCChannelCount
  • Bring fields up-to-date with spec change, removing SpatialAxes, RotationOrder, RotationRule
  • Remove unused field TrackingSystemCount

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.29% ⚠️

Comparison is base (6677c9a) 85.68% compared to head (a918db2) 83.40%.

❗ Current head a918db2 differs from pull request most recent head abde27b. Consider uploading reports for the commit abde27b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1791      +/-   ##
==========================================
- Coverage   85.68%   83.40%   -2.29%     
==========================================
  Files         130       92      -38     
  Lines        6582     3893    -2689     
  Branches     1525     1270     -255     
==========================================
- Hits         5640     3247    -2393     
+ Misses        836      548     -288     
+ Partials      106       98       -8     

see 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff sappelhoff requested a review from rwblair August 25, 2023 15:49
@rwblair rwblair merged commit 4d7cbdc into bids-standard:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants