Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bval): Handle trailing whitespace without newlines #92

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Nov 7, 2024

Fixes #9, adds a test that fails thus (if we revert the second commit):

Test bval/bvec parsing ... Load 3 bvals - missing newline => ./src/files/dwi.test.ts:10:11
error: AssertionError: Values are not equal.


    [Diff] Actual / Expected


    [
      [
        "0",
        "1",
        "2",
-       "",
      ],
    ]

  throw new AssertionError(message);
        ^
    at assertEquals (https://jsr.io/@std/assert/1.0.7/equals.ts:51:9)
    at file:///home/chris/Projects/bids/validator/src/files/dwi.test.ts:12:5
    at innerWrapped (ext:cli/40_test.js:191:11)
    at exitSanitizer (ext:cli/40_test.js:107:33)
    at Object.outerWrapped [as fn] (ext:cli/40_test.js:134:20)
    at TestContext.step (ext:cli/40_test.js:492:37)
    at file:///home/chris/Projects/bids/validator/src/files/dwi.test.ts:10:11

Test bval/bvec parsing ... Load 3 bvals - missing newline => ./src/files/dwi.test.ts:22:11
error: AssertionError: Values are not equal.


    [Diff] Actual / Expected


    [
      [
        "0",
        "1",
        "2",
      ],
      [
        "0",
        "1",
        "2",
      ],
      [
        "0",
        "1",
        "2",
-       "",
      ],
    ]

  throw new AssertionError(message);
        ^
    at assertEquals (https://jsr.io/@std/assert/1.0.7/equals.ts:51:9)
    at file:///home/chris/Projects/bids/validator/src/files/dwi.test.ts:24:5
    at innerWrapped (ext:cli/40_test.js:191:11)
    at exitSanitizer (ext:cli/40_test.js:107:33)
    at Object.outerWrapped [as fn] (ext:cli/40_test.js:134:20)
    at TestContext.step (ext:cli/40_test.js:492:37)
    at file:///home/chris/Projects/bids/validator/src/files/dwi.test.ts:22:11

 FAILURES

Test bval/bvec parsing ... Load 3 bvals - missing newline => ./src/files/dwi.test.ts:10:11
Test bval/bvec parsing ... Load 3 bvals - missing newline => ./src/files/dwi.test.ts:22:11

FAILED | 47 passed (652 steps) | 1 failed (2 steps) (21s)

error: Test failed

@rwblair rwblair merged commit dd8a5b3 into bids-standard:main Nov 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different validator outputs between webapp version and command line version
2 participants